Matthew

← PhotoSwipe Feedback Forum

My feedback

  1. Click to advance to next image

    26 votes
    Vote
    Sign in
    (thinking…)
    Sign in with: Facebook Google
    Forgot password?
    Create a password
    Signed in as (Sign out)
    Close
    Close
    You have left! (?) (thinking…)
    7 comments  ·  Feature Requests & Ideas  ·  Flag idea as inappropriate…  ·  Admin →
    Matthew commented  · 

    On second look, I realize that the dual conditions are redundant. The function can be more simple:

    if(framework.hasClass(target, 'pswp__img')) {
    if(_options.clickToAdvanceImage) {
    if(pswp.getZoomLevel() <= pswp.currItem.fitRatio) {
    pswp.next();
    } else {
    pswp.toggleDesktopZoom(e.detail.releasePoint);
    }
    } else {
    if(pswp.getZoomLevel() === 1 && pswp.getZoomLevel() <= pswp.currItem.fitRatio) {
    if(_options.clickToCloseNonZoomable) {
    pswp.close();
    }
    } else {
    pswp.toggleDesktopZoom(e.detail.releasePoint);
    }
    }
    }

    Matthew commented  · 

    I've got this working more or less the way I'd like. Feel free to add or update this functionality in the main branch if you'd like. The changes are all made to photoswipe-ui-default.js.

    Around line 77, change:

    clickToCloseNonZoomable: true,

    To:

    clickToAdvanceImage: true,
    clickToCloseNonZoomable: true,

    ----

    Around line 735, update the function:

    if(framework.hasClass(target, 'pswp__img')) {
    if(pswp.getZoomLevel() === 1 && pswp.getZoomLevel() <= pswp.currItem.fitRatio) {
    if(_options.clickToCloseNonZoomable) {
    pswp.close();
    }
    } else {
    pswp.toggleDesktopZoom(e.detail.releasePoint);
    }
    }

    To:

    if(framework.hasClass(target, 'pswp__img')) {
    if(_options.clickToAdvanceImage) {
    if(( pswp.getZoomLevel() === 1 && pswp.getZoomLevel() <= pswp.currItem.fitRatio )
    || pswp.getZoomLevel() === pswp.currItem.fitRatio) {
    pswp.next();
    } else {
    pswp.toggleDesktopZoom(e.detail.releasePoint);
    }
    } else {
    if(pswp.getZoomLevel() === 1 && pswp.getZoomLevel() <= pswp.currItem.fitRatio) {
    if(_options.clickToCloseNonZoomable) {
    pswp.close();
    }
    } else {
    pswp.toggleDesktopZoom(e.detail.releasePoint);
    }
    }
    }

    Matthew shared this idea  · 

Feedback and Knowledge Base

(thinking…)